-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cxl-ui): cxl-marketing-nav menu bar button alignment on desktop #442
base: master
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
Visit the preview URL for this PR (updated for commit 838bc37): https://aybolit-449f1--pr442-anoblet-fix-menu-bar-ljlc348j.web.app (expires Fri, 10 Jan 2025 15:49:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ebc08d8a89b4eb54ebfb0bb50bd15f151f1243f5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the faded red background for the close icon and changed the nav bar padding from |
e254a7e
to
486116c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anoblet I deployed it live, looks good in most places but on the dashboard menu is wider than content. I see it uses 1c-w
layout.
Please check more non-standard pages on institute so we know if this is just dashboard issue or wider problem.
If just dashboard, propose solution
Logo icon itself should absolutely have 0 / zero padding. Anything else is a bug. |
486116c
to
838bc37
Compare
https://app.clickup.com/t/86b2hv84w
Desktop:
Mobile: