Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated what_format and why_format from JSON API petition example #148

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

lavaturtle
Copy link

Historically, some effort petitions were formatted by including Markdown syntax in the text. To let JSON API users know how the text should be interpreted, the response for the /petitions/foo.json endpoint included fields what_format and why_format, which could be either "plain" or "markdown".

Now that we have migrated all efforts to rich-text defaults, these fields are always returning "plain", which is not useful and may be misleading for rich text with HTML markup in it. So we are deprecating the what_format and why_format fields in the API response, and will remove them in a little while.

As a first step, this PR removes what_format and why_format from the example response in the API documentation.

image

@lavaturtle lavaturtle added the merge-candidate This PR is ready to be merged, once it is reviewed and tested label Jun 7, 2024
Copy link

@anero anero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lavaturtle lavaturtle merged commit 2fb2799 into mf-cs-documentation Jun 7, 2024
2 checks passed
@lavaturtle lavaturtle deleted the deprecate-field-format branch June 7, 2024 13:39
lavaturtle added a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate This PR is ready to be merged, once it is reviewed and tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants