Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for Attendee and Signature create #138

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Improve documentation for Attendee and Signature create #138

merged 3 commits into from
Mar 15, 2024

Conversation

lavaturtle
Copy link

This makes several tweaks to clarify how to create an Attendee or a Signature:

  • Adds missing fields attending_status and notification_level to the table of fields for Attendee create
  • Adds a full working JSON request example for Attendee create
  • Adjusts how the fields for Attendee and Signature create are presented, to be clearer about the JSON format and which fields are required

image
image

@lavaturtle lavaturtle added the merge-candidate This PR is ready to be merged, once it is reviewed and tested label Mar 15, 2024
anero
anero approved these changes Mar 15, 2024
View reviewed changes
Copy link

@anero anero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@lavaturtle lavaturtle merged commit 40543f8 into mf-cs-documentation Mar 15, 2024
2 checks passed
@lavaturtle lavaturtle deleted the attendee-create branch March 15, 2024 15:44
lavaturtle added a commit that referenced this pull request Mar 15, 2024
@lavaturtle
publish: Improve documentation for Attendee and Signature create (#138)
b4bab80 
generated from commit 40543f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anero anero anero approved these changes

Assignees
No one assigned
Labels
merge-candidate This PR is ready to be merged, once it is reviewed and tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavaturtle @anero