Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluxInstance: Add artifactPullSecret to spec.distribution #145

Merged
merged 1 commit into from
Jan 16, 2025
Merged

FluxInstance: Add artifactPullSecret to spec.distribution #145

merged 1 commit into from
Jan 16, 2025

Conversation

ahothan
Copy link
Contributor

@ahothan ahothan commented Jan 14, 2025 •
edited by matheuscscp
Loading

Closes #139

stefanprodan
stefanprodan reviewed Jan 14, 2025
View reviewed changes
internal/controller/fluxinstance_controller.go Outdated Show resolved Hide resolved
api/v1/fluxinstance_types.go Outdated Show resolved Hide resolved
@stefanprodan stefanprodan changed the title Add manifestPullSecret to spec.distribution FluxInstance: Add manifestPullSecret to spec.distribution Jan 15, 2025
@stefanprodan stefanprodan added area/api API related issues and pull requests area/update-automation Flux update automation related issues and pull requests labels Jan 15, 2025
@stefanprodan stefanprodan changed the title FluxInstance: Add manifestPullSecret to spec.distribution FluxInstance: Add artifactPullSecret to spec.distribution Jan 15, 2025
@stefanprodan
Copy link
Member

@ahothan this looks good can you please squash the commits into FluxInstance: Add artifactPullSecret to spec.distribution and rebase with main.

matheuscscp
matheuscscp reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one last comment. Thanks for the contribution!

internal/controller/fluxinstance_controller.go Outdated Show resolved Hide resolved
@ahothan
Copy link
Contributor Author

ahothan commented Jan 16, 2025

I have addressed the last comment from @matheuscscp (adjust if else block) and squashed all commits.
Thank you for the review.

matheuscscp
matheuscscp approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahothan!

@stefanprodan stefanprodan merged commit a06fccd into controlplaneio-fluxcd:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@matheuscscp matheuscscp matheuscscp approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests area/update-automation Flux update automation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need authentication to pull the flux-operator-manifests from a private OCI registry
3 participants
@ahothan @stefanprodan @matheuscscp