Added fixes to ignore errors because of GitHub token #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: web/modules/custom/ct_github/src/GithubQuery.php
Did you find this useful? React with a 👍 or 👎 |
Yemaneberhan-Lemma
temporarily deployed
to
feature
GitHub Actions
Inactive
hussainweb
reviewed
Nov 11, 2024
Comment on lines
+99
to
+101
| if (!$issues) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why is this needed? IIRC, $issues will always be an array and the foreach won't do anything. I am avoiding this return because there might be more things to run later. Are there cases where not having this throws an error?
hussainweb
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes for the issue