-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for updated react version [TOL-2633] #756
Conversation
@YvesRijckaert this is currently blocking installing Studio SDK (which has a dep on rich-text-react-renderer) into new Next.js v15 apps. Not an emergency, just an FYI. |
is it only blocked by the snapshots? could be maybe update the tests to not use snapshots instead? 🤔 |
We can probably also switch to vitest since we are using it in our other libraries |
We still have jest as adopt on the tech radar, if we would like to switch to vitest, we should do this more generally and bring it up in the chapter meeting Tomorrow would be one ;) |
a84d79c
to
0dd7456
Compare
Size Change: 0 B Total Size: 75.4 kB ℹ️ View Unchanged
|
Update: I've delayed updating react internally in rich text renderer until the jest issue has been fixed. Migrating away from snapshots would have been a huge task because there are over 30 tests using snapshots. I tested it with just updating peerDependencies and everything worked ok |
Add support for projects with react version 19 for rich text react renderer package
We do not upgrade the dev dependency of React for this package since snapshot tests are failing with the new version. It is blocked until this is fixed: jestjs/jest#15402
Testing