Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/if rework #696

Closed
wants to merge 3 commits into from
Closed

Feat/if rework #696

wants to merge 3 commits into from

Conversation

neumie
Copy link
Contributor

@neumie neumie commented May 6, 2024 •
edited
Loading

I've reworked the If component.

The condition prop works the same way, but for the If logic to work you need to pass in either Then or Else components, which will render accordingly to the condition.

This PR also updates the engine to v1.4.0-rc.1

@neumie neumie added the enhancement New feature or request label May 6, 2024
@neumie neumie requested a review from matej21 May 6, 2024 09:47
@neumie neumie self-assigned this May 6, 2024
@matej21 matej21 mentioned this pull request May 13, 2024
Merged
@matej21
Copy link
Member

matej21 commented May 27, 2024

I've merged that version with then-else props instead, as it is backward compatibile #700

@matej21 matej21 closed this May 27, 2024
@matej21 matej21 deleted the feat/if-rework branch June 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej21 matej21 Awaiting requested review from matej21

Assignees

@neumie neumie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neumie @matej21