Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update an expected error message #2442

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Oct 14, 2024

containers/image#2595 will change it.

This should work with current c/image; #2441 tests whether it will work with the proposed change.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mtrmac mtrmac marked this pull request as ready for review October 14, 2024 19:17
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
but it looks like a rebase is needed @mtrmac

containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac
Copy link
Contributor Author

mtrmac commented Nov 20, 2024

Rebased.

@TomSweeneyRedHat
Copy link
Member

/approved

@TomSweeneyRedHat
Copy link
Member

/lgtm

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat TomSweeneyRedHat merged commit 87f199f into containers:main Nov 20, 2024
23 checks passed
@mtrmac mtrmac deleted the error-change branch November 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants