Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacked 4/5] metrics: add policy system collector. #405

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Nov 11, 2024

Notes: This PR is stacked on top of #408.

Implement collection of policy 'system' prometheus metrics.
For each memory node collect
- memory capcity
- memory usage
- number of containers sharing the node
For each CPU core collect
- total container allocations from that core
- number of containers sharing the core

@klihub klihub force-pushed the metrics/policy-system-collector branch 2 times, most recently from f0856b2 to bfc293d Compare November 11, 2024 22:58
@klihub klihub changed the title [3/4] metrics: add policy system collector. [4/5] metrics: add policy system collector. Nov 11, 2024
Copy link

@pfl pfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub force-pushed the metrics/policy-system-collector branch 4 times, most recently from 90e774c to ac2049d Compare November 13, 2024 09:44
@klihub klihub marked this pull request as ready for review November 13, 2024 13:29
@klihub klihub changed the title [4/5] metrics: add policy system collector. [stack: 4/5] metrics: add policy system collector. Nov 13, 2024
@klihub klihub changed the title [stack: 4/5] metrics: add policy system collector. [stacked 4/5] metrics: add policy system collector. Nov 13, 2024
@klihub klihub force-pushed the metrics/policy-system-collector branch 12 times, most recently from ee14a29 to 2f9a345 Compare November 18, 2024 12:54
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub force-pushed the metrics/policy-system-collector branch from 2f9a345 to 10d0bc0 Compare November 19, 2024 13:42
@klihub klihub force-pushed the metrics/policy-system-collector branch 2 times, most recently from 43f9830 to 364bc33 Compare November 20, 2024 08:11
Implement collection of policy 'system' prometheus metrics.

We collect per each memory node
  - memory capcity
  - memory usage
  - number of containers sharing the node

We collect per each CPU core
  - allocation from that core
  - number of containers sharing the core

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the metrics/policy-system-collector branch from 364bc33 to 9c64cc6 Compare November 20, 2024 08:17
@askervin askervin merged commit 91dc7b5 into containers:main Nov 20, 2024
3 checks passed
@klihub klihub deleted the metrics/policy-system-collector branch November 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants