add support for default credential store #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koshatul
force-pushed
the
add-credstore-support
branch
from
38b296b to
869c633
Compare
mtrmac
reviewed
Nov 1, 2019
Signed-off-by: Kosh <[email protected]>
changed order of importance for auths.CredStore, and added functions for using RemoveAll with credential helpers Signed-off-by: Kosh <[email protected]>
Signed-off-by: Kosh <[email protected]>
koshatul
force-pushed
the
add-credstore-support
branch
from
251cab8 to
77f9895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
Added a check for
credsStorein the${HOME}/.docker/config.jsonfile, at least on OSX theauthslist is just URIs and there isn't acredHelperslist.Why make this change?
To implement authentication when using applications that import this library on OSX and possibly other BSD/*nix OS
What approach will be taken?
Implement the check for a default credentials store past the registry specific
credHelperslist.