Copy latest distribution/reference to support ipv6 #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Copy&pasting #2618 (review) :
- https://github.com/containers/image/blob/main/CONTRIBUTING.md#sign-your-prs please, I’m afraid we can’t even look at contributions with unclear copyright status
⚠️ Other reviewers, DO NOT MERGE blindly. If nothing else, we are already using the[…]syntax forcontainers-storage:store options, so this probably introduces an ambiguity. This needs a careful compatibility analysis.
Signed-off-by: zuzuviewer <[email protected]>
|
@mtrmac I don't know how to fix this test, could you please do some help or give some good suggestions |
|
@zuzuviewer As I said above, introducing this format change would require much more analysis (or possibly migration design) than “do tests pass”, and I’m afraid I can’t spend time on that for the next few months at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy latest distribution/reference to support ipv6