Remove check for empty location from parseLocation

Empty location is now allowed with a valid prefix, and we check for these in postProcessRegistries already. This check doesn't need to exist. Fixes: #1191 (comment) Signed-off-by: Lokesh Mandvekar <[email protected]>
containers · Sep 23, 2021 · 85d3927 · 85d3927
1 parent 63bb4cb
commit 85d3927
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/pkg/sysregistriesv2/system_registries_v2.go b/pkg/sysregistriesv2/system_registries_v2.go
@@ -264,16 +264,6 @@ func (e *InvalidRegistries) Error() string {
 func parseLocation(input string) (string, error) {
 	trimmed := strings.TrimRight(input, "/")
 
-	// FIXME: This check needs to exist but fails for empty Location field with
-	// wildcarded prefix. Removal of this check "only" allows invalid input in,
-	// and does not prevent correct operation.
-	// https://github.com/containers/image/pull/1191#discussion_r610122617
-	//
-	//	if trimmed == "" {
-	//		return "", &InvalidRegistries{s: "invalid location: cannot be empty"}
-	//	}
-	//
-
 	if strings.HasPrefix(trimmed, "http://") || strings.HasPrefix(trimmed, "https://") {
 		msg := fmt.Sprintf("invalid location '%s': URI schemes are not supported", input)
 		return "", &InvalidRegistries{s: msg}