Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/containernetworking/plugins to v1.6.1 #2259

Closed

fix(deps): update module github.com/containernetworking/plugins to v1…

2930972
Select commit
Loading
Failed to load commit list.
Closed

fix(deps): update module github.com/containernetworking/plugins to v1.6.1 #2259

fix(deps): update module github.com/containernetworking/plugins to v1…
2930972
Select commit
Loading
Failed to load commit list.
Cirrus CI / Testing on fedora-41 failed Dec 2, 2024 in 2m 13s

Task Summary

Instruction test failed in 01:59

Details

✅ 00:12 clone
❌ 01:59 test

+		if err != nil {
+			err = fmt.Errorf("failed to open current namespace: %v", err)
+			return
+		}
+		defer threadNS.Close()
+
+		// create the temporary network namespace
+		err = unix.Unshare(unix.CLONE_NEWNET)
+		if err != nil {
+			return
+		}
+
+		// get a handle to the temporary network namespace
+		tempNS, err = getCurrentNSNoLock()
+
+		err2 := threadNS.Set()
+		if err2 == nil {
+			// Unlock the current thread only when we successfully switched back
+			// to the original namespace; otherwise leave the thread locked which
+			// will force the runtime to scrap the current thread, that is maybe
+			// not as optimal but at least always safe to do.
+			runtime.UnlockOSThread()
+		}
+	}()
+
+	wg.Wait()
+	return tempNS, err
+}
+
 func (ns *netNS) Path() string {
 	return ns.file.Name()
 }
@@ -173,7 +225,7 @@ func (ns *netNS) Do(toRun func(NetNS) error) error {
 	}
 
 	containedCall := func(hostNS NetNS) error {
-		threadNS, err := GetCurrentNS()
+		threadNS, err := getCurrentNSNoLock()
 		if err != nil {
 			return fmt.Errorf("failed to open current netns: %v", err)
 		}
diff --git a/vendor/modules.txt b/vendor/modules.txt
index 55233415..405fb3d0 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -95,8 +95,8 @@ github.com/containernetworking/cni/pkg/types/create
 github.com/containernetworking/cni/pkg/types/internal
 github.com/containernetworking/cni/pkg/utils
 github.com/containernetworking/cni/pkg/version
-# github.com/containernetworking/plugins v1.5.1
-## explicit; go 1.20
+# github.com/containernetworking/plugins v1.6.1
+## explicit; go 1.23
 github.com/containernetworking/plugins/pkg/ns
 # github.com/containers/image/v5 v5.33.0
 ## explicit; go 1.22.6