Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Makefile for chatbot #124

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Cleanup Makefile for chatbot #124

merged 1 commit into from
Apr 1, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 30, 2024

No description provided.

.PHONY: build
build:
podman build -f builds/Containerfile -t ghcr.io/ai-lab-recipes/${APP} .

.PHONY: bootc
bootc:
podman build --cap-add SYS_ADMIN --build-arg "SSHPUBKEY=$(SSHPUBKEY)" -f bootc/Containerfile -t ghcr.io/ai-lab-recipes/${APP}-bootc .
sudo podman build --cap-add SYS_ADMIN --build-arg "SSHPUBKEY=$(SSHPUBKEY)" -f bootc/Containerfile -t ghcr.io/ai-lab-recipes/${APP}-bootc .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tricky though because then this Makefile won't do the right thing on MacOS (and I think we want that right?)

So this goes back to using podman-machine even on Linux right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work on MacOS - If i'm running rootful podman machine I can run podman or sudo podman they both work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, on my Mac with podman v5 - I need to add --network=host in order to build this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also, on Mac, I cannot run nested podman cmds during podman build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the sudo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it really means is requiring users to use rootful containers or figuring out why this is not working on rootless mode.

Signed-off-by: Daniel J Walsh <[email protected]>
@sallyom sallyom merged commit 3396290 into containers:main Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants