-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Makefile for chatbot #124
Conversation
.PHONY: build | ||
build: | ||
podman build -f builds/Containerfile -t ghcr.io/ai-lab-recipes/${APP} . | ||
|
||
.PHONY: bootc | ||
bootc: | ||
podman build --cap-add SYS_ADMIN --build-arg "SSHPUBKEY=$(SSHPUBKEY)" -f bootc/Containerfile -t ghcr.io/ai-lab-recipes/${APP}-bootc . | ||
sudo podman build --cap-add SYS_ADMIN --build-arg "SSHPUBKEY=$(SSHPUBKEY)" -f bootc/Containerfile -t ghcr.io/ai-lab-recipes/${APP}-bootc . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tricky though because then this Makefile
won't do the right thing on MacOS (and I think we want that right?)
So this goes back to using podman-machine even on Linux right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work on MacOS - If i'm running rootful podman machine I can run podman
or sudo podman
they both work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however, on my Mac with podman v5 - I need to add --network=host
in order to build this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also, on Mac, I cannot run nested podman cmds during podman build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the sudo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it really means is requiring users to use rootful containers or figuring out why this is not working on rootless mode.
Signed-off-by: Daniel J Walsh <[email protected]>
No description provided.