Merge pull request #634 from lstocchi/fixMakefile

fix: add build_vulkan commands for amd64/arm64 on Makefile
containers · Jun 27, 2024 · 5462be9 · 5462be9
2 parents aa0e2e4 + 3794186
commit 5462be9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/model_servers/llamacpp_python/Makefile b/model_servers/llamacpp_python/Makefile
@@ -19,9 +19,11 @@ all: build download-model-granite run
 build-cuda:
 	"${CONTAINER_TOOL}"  build --squash-all -t $(CUDA_IMAGE) . -f cuda/Containerfile
 
-.PHONY: build-vulkan
-build-vulkan:
-	"${CONTAINER_TOOL}"  build --squash-all -t $(VULKAN_IMAGE) . -f vulkan/Containerfile
+.PHONY: build-vulkan-amd64 build-vulkan-arm64
+build-vulkan-amd64:
+	"${CONTAINER_TOOL}"  build --squash-all -t $(VULKAN_IMAGE) . -f vulkan/amd64/Containerfile
+build-vulkan-arm64:
+	"${CONTAINER_TOOL}"  build --squash-all -t $(VULKAN_IMAGE) . -f vulkan/arm64/Containerfile
 
 .PHONY: download-model-granite # default model
 download-model-granite:

diff --git a/model_servers/llamacpp_python/README.md b/model_servers/llamacpp_python/README.md
@@ -61,9 +61,11 @@ The [Vulkan image](../llamacpp_python/vulkan/Containerfile) is experimental, but
 
 To build the Vulkan model service variant image:
 
-```bash
-make -f Makefile build-vulkan
-```
+| System Architecture | Command |
+|---|---|
+| amd64 | make -f Makefile build-vulkan-amd64 |
+| arm64 | make -f Makefile build-vulkan-arm64 |
+
 To pull the base model service image:
 
 ```bash