CI: go install action #3760
CI: go install action #3760
Conversation
apostasie
force-pushed
the
ci-go-setup-action
branch
11 times, most recently
from
f709131 to
cb49ffc
Compare
|
Failures are #3761 and some random network fluke. |
|
@AkihiroSuda ready to go, though this is based on top of #3739 which needs to go first. |
|
Note that this (temporarily?) disable cache for setup-go, in light of ongoing issues (429) with github provided caching mechanism. |
apostasie
force-pushed
the
ci-go-setup-action
branch
from
cb49ffc to
75cc2eb
Compare
| done < \ | ||
| <(sed -E 's/^go([0-9]+)[.]([0-9]+)([.]([0-9]+))?(([a-z]+)([0-9]+))?/\1.\2\n\4\n\6\n\7/i' \ | ||
| <(curl -fsSL "https://go.dev/dl/?mode=json&include=all" | jq -rc .[0].version) \ | ||
| ) |
There was a problem hiding this comment.
That should clean-up our CI files a tad, and allow for much simpler / centralized maintenance, and also better control over usage of cache.
Sorry, I feel that the maintenance cost is rather increasing with this PR
There was a problem hiding this comment.
Rebased to remove the noise.
This particular code has just been moved out of a helper script, so, I am not completely sure what is perceived as adding complexity.
Anyhow, it is fine - these type of feelings are not something we can really argue about. I'll close.
apostasie
force-pushed
the
ci-go-setup-action
branch
from
75cc2eb to
7c178d9
Compare
The new action will centralize go version so we stop having them peppered accross different files. It also provides simple "strategies" that cover all our cases (canary, latest-stable, old-stable). Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
ci-go-setup-action
branch
from
7c178d9 to
33c5861
Compare
Currently, we carry GO_VERSION around in a bunch of files, along with calls to
actions/setup-go, which also comes with it pinned version.This here suggests we centralize all of that inside a new, in-tree github action that also bundles in the logic for canary and simplify pulling go for the consumer:
strategy latest-stablewill retrieve the latest patch for the main go version (eg: 1.23.x)strategy old-stablewill retrieve the latest patch for the previous go version (eg: 1.22.x)strategy canarywill retrieve the latest RCThat should clean-up our CI files a tad, and allow for much simpler / centralized maintenance, and also better control over usage of cache.