Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build trigger for 8.3.0 #61

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Xerkus
Copy link
Contributor

@Xerkus Xerkus commented Nov 23, 2023

PHP 8.3.0 just released

I believe this is blocked by php-build/php-build#759

Signed-off-by: Aleksei Khudiakov <[email protected]>
@rarkins rarkins added this pull request to the merge queue Nov 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 24, 2023
@rarkins rarkins added this pull request to the merge queue Nov 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 24, 2023
@rarkins
Copy link
Member

rarkins commented Nov 24, 2023

@viceice any ideas?

image

@viceice viceice merged commit 50a5654 into containerbase:main Nov 24, 2023
5 checks passed
@viceice
Copy link
Member

viceice commented Nov 24, 2023

@viceice any ideas?

image

merge group was missing on workflow trigger

@Xerkus
Copy link
Contributor Author

Xerkus commented Nov 24, 2023

How did this get built considering that php-build does not have 8.3.0 yet? Is it no longer a dependency?

@viceice
Copy link
Member

viceice commented Nov 24, 2023

it's not build until that definition updated is merged.

currently PHP 8.3 isn't on docker hub, so it's not tried to build.

@viceice
Copy link
Member

viceice commented Nov 24, 2023

this trigger file is just to get commits to main to trigger GitHub actions. the action is then trying to build all missing PHP versions (besides explicit excluded via config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants