Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform support #225

Closed
wants to merge 1 commit into from
Closed

platform support #225

wants to merge 1 commit into from

Conversation

hef
Copy link

@hef hef commented May 15, 2021

closes #241

@hef
Copy link
Author

hef commented May 15, 2021

relevant to containerbase/base#47

@viceice viceice self-requested a review May 15, 2021 07:07
@hef
Copy link
Author

hef commented May 16, 2021

This should also help make renovatebot/renovate#9229 solvable.

@viceice
Copy link
Member

viceice commented May 16, 2021

I need some more time to think about it. Currently we only push a new image when the if has changed. For multi platform builds it makes that a lot more complicated. We should publish platform suffixed images first and then a image list manifest containing all platforms. This should only happen if image IDs change. Otherwise the release timestamp of our images will move constantly. We don't like that default docker push behavior that's why we implemented it like it is now.

Maybe we need to accept those changes to have more simplified builds with buildx (bake).

Another this we first need it to update the containerbase binary prebuilds. They need to build the arm binaries before we can build any docker images for arm.

@viceice viceice marked this pull request as draft July 7, 2021 09:04
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #241 for required implementation features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-builder: Support multiarch (arm64)
2 participants