Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): convert java installer #2749

Merged
merged 6 commits into from
Jun 4, 2024
Merged

feat(cli): convert java installer #2749

merged 6 commits into from
Jun 4, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Jun 4, 2024 •
edited
Loading

Just convert the installer to typescript, so it uses the url replacements.

@viceice viceice requested a review from rarkins June 4, 2024 07:01
viceice
viceice commented Jun 4, 2024
View reviewed changes
src/cli/tools/java/index.ts Outdated Show resolved Hide resolved
@viceice viceice merged commit b4c96f2 into main Jun 4, 2024
30 of 32 checks passed
@viceice viceice deleted the feat/java-installer branch June 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
tool/java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viceice @rarkins