-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support url rewrite #1210
Conversation
We can phase out the bats tests whenever we replace functionality with typescript |
fixed the tests. I'm not sure if i need the file delete 🤔 |
https://stackoverflow.com/questions/37176783/node-js-fs-more-efficient-way-to-create-file-clear-file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get docs for the URL rewriting if this closes the issue?
there are already some docs and all urls are printed on debug log level |
??? |
Not sure where that came from. Can you point me to the docs? |
https://github.com/containerbase/base/tree/feat/url-replace#url-replacement will create a mother extended version in later PR's. will try to extract the base urls to variables, so I can use a test to validate docs to have a sample for each of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to block this but we need conclusive docs for rewriting all URLs in a "full" image
yes, will update docs later. currently it's best to try and error to see failed urls in logs. then it should be easy to rewrite them. |
We now call back into our new cli to download the file, so the new url replacement can be applied.
Will add some more documentation too later.