Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to explicitly specify the transport to use for a site-alias #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceesgeene
Copy link
Contributor

Overview

This pull request:

Q A
Bug fix? no
New feature? yes
Has tests? yes
BC breaks? no
Deprecations? no

Summary

This allows to explicitly specify the transport to use.

Description

This for example allows for the use of the host property, without automatically forcing the ssh transport.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #71 (1e51630) into main (49ec2b9) will increase coverage by 0.83%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
+ Coverage     77.85%   78.68%   +0.83%     
- Complexity      174      177       +3     
============================================
  Files            20       20              
  Lines           438      441       +3     
============================================
+ Hits            341      347       +6     
+ Misses           97       94       -3     
Impacted Files Coverage Δ
src/ProcessManager.php 76.74% <91.66%> (-0.76%) ⬇️
src/Transport/KubectlTransport.php 88.88% <0.00%> (+7.40%) ⬆️
src/Factory/KubectlTransportFactory.php 100.00% <0.00%> (+50.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant