Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Config.php for PHP 8.4 #64

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

andypost
Copy link
Contributor

@andypost
Copy link
Contributor Author

PHP Deprecated:  Consolidation\Config\Config::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/vendor/consolidation/config/src/Config.php on line 33

Deprecated: Consolidation\Config\Config::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/vendor/consolidation/config/src/Config.php on line 33

@greg-1-anderson
Copy link
Member

I'll make new releases with 8.4 support as soon as the CI config is updated to cover 8.4. Will do that as soon as I'm able; PRs also welcome.

@greg-1-anderson greg-1-anderson merged commit 93a820e into consolidation:main Jul 23, 2024
5 checks passed
@andypost andypost deleted the patch-1 branch July 23, 2024 16:55
@andypost
Copy link
Contributor Author

@greg-1-anderson CI already can use 8.4 but as I see there's no matrix testing for the package

@greg-1-anderson
Copy link
Member

@andypost The matrix is not regular / complete, as I didn't want to test both Linux and Windows across all php versions. Currently, only PHP 8.2 is tested on both Linux and Windows; PHP 8.3 is added in via an "include". PHP 8.4 could be another element in this include list.

@andypost andypost mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants