stop calling static methods in tests as non-static

consistence · Mar 9, 2023 · a5ce432 · a5ce432
1 parent 408c753
commit a5ce432
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/tests/LazyRobotLoaderClassFinderTest.php b/tests/LazyRobotLoaderClassFinderTest.php
@@ -16,7 +16,7 @@ public function testRebuildRobotLoaderOnlyOnFirstRun(): void
 			->setMethods(['rebuild'])
 			->getMock();
 		$robotLoader
-			->expects($this->once())
+			->expects(self::once())
 			->method('rebuild');
 
 		$lazyClassFinder = new LazyRobotLoaderClassFinder($robotLoader);

diff --git a/tests/RobotLoaderClassFinderTest.php b/tests/RobotLoaderClassFinderTest.php
@@ -5,6 +5,7 @@
 namespace Consistence\ClassFinder\RobotLoader;
 
 use Nette\Loaders\RobotLoader;
+use PHPUnit\Framework\Assert;
 
 class RobotLoaderClassFinderTest extends \PHPUnit\Framework\TestCase
 {
@@ -13,8 +14,8 @@ public function testFindClass(): void
 	{
 		$classList = array_values($this->getRobotLoaderClassFinder()->findByInterface(ExtendingClass::class));
 
-		$this->assertContains(ExtendingClass::class, $classList);
-		$this->assertCount(1, $classList);
+		Assert::assertContains(ExtendingClass::class, $classList);
+		Assert::assertCount(1, $classList);
 	}
 
 	public function testFindClassAndChildren(): void
@@ -27,15 +28,15 @@ public function testFindClassAndChildren(): void
 			ExtendingClass::class,
 		];
 
-		$this->assertEquals($expected, $classList);
+		Assert::assertEquals($expected, $classList);
 	}
 
 	public function testFindInterface(): void
 	{
 		$classList = array_values($this->getRobotLoaderClassFinder()->findByInterface(NotImplementedInterface::class));
 
-		$this->assertContains(NotImplementedInterface::class, $classList);
-		$this->assertCount(1, $classList);
+		Assert::assertContains(NotImplementedInterface::class, $classList);
+		Assert::assertCount(1, $classList);
 	}
 
 	public function testFindInterfaceAndImplementations(): void
@@ -50,7 +51,7 @@ public function testFindInterfaceAndImplementations(): void
 			ExtendingInterface::class,
 		];
 
-		$this->assertEquals($expected, $classList);
+		Assert::assertEquals($expected, $classList);
 	}
 
 	private function getRobotLoaderClassFinder(): RobotLoaderClassFinder