Mmi 3924 implement new de fi adapter for uniswap v 3 in new repo

[jpsains]

No description provided.

[bergarces]

Is this contract likely to be needed in future? It doesn't look like it's being used here.

[jpsains]

ill remove until its needed

[bergarces]

This could result in a pretty big loop. We might want to come back to this eventually.

[bergarces]

I'm unsure what the best policy would be here.

I'm pretty sure we could have a single async map that returns nonZeroPositions directly without looping three times with something like this.

const nonZeroPositions = await Promise.all(
      filterMap([...Array(Number(balanceOf)).keys()], async (index) => {
        const tokenId = await positionsManagerContract.tokenOfOwnerByIndex(
          userAddress,
          index,
          {
            blockTag: blockNumber,
          },
        )

        const position = await positionsManagerContract.positions(tokenId, {
          blockTag: blockNumber,
        })

        if (position.liquidity == 0n) {
          return undefined
        }

        return {
          liquidity: position.liquidity,
          token0: position.token0,
          token1: position.token1,
          fee: position.fee,
          tokenId: tokenIds[index],
        }
      }),
    )

I'm unsure whether it'll save any time at all. We would need to run profiling with users with a lot of positions.

[bergarces]

Actually ignore my previous code. It won't work as filterMap doesn't work with promises.

[jpsains]

ive implemented