Added function related to the debugger #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Pavlovic <[email protected]>
# Conflicts: # pkg/eventlog/eventwriter.go # pkg/eventlog/eventwritergzip.go # pkg/eventlog/eventwritersqlite.go # pkg/eventlog/recorder.go # workers.go
…ventList and an error
matejpavlovic
suggested changes
Dec 14, 2023
cleaned up newWSWriter(), add optional -d flag for debug mode and refactor argument parsing
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
approved these changes
Feb 5, 2024
|
I pushed another commit, simplifying a part of the code (avoiding conversions from |
…tion use logger in Write
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
debugger
branch
from
40583f4 to
12827ef
Compare
matejpavlovic
merged commit 886b601
into
consensus-shipyard:visualization
3 checks passed
komplexon3
pushed a commit
to komplexon3/mir
that referenced
this pull request
Mar 29, 2024
Generalize and simplify the interceptor Generalize: The interceptor can now interfere with the intercepted events. Instead of returning just an error value, it now also returns an `EventList`. It is those returned events (instead of the input events) that Mir uses for delivering to its modules. Simplify: The `EventRecord`s have been overused in parts of the code where they did not necessarily belong. They are now replaced by simple `EventList`s wherever appropriate. Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Add run.sh to pingpong for convenience Signed-off-by: Matej Pavlovic <[email protected]> Implement WebSocket debugger (consensus-shipyard#528) Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Add Mir debugger frontend (consensus-shipyard#527) Create frontend to connect to MIR nodes to accept or decline new log messages Co-authored-by: Andrea Jiang <[email protected]> Event modification through frontend (consensus-shipyard#541) * added the replace event functionality for the debugger in the backend, using protojson.Marshal instead of json.Marshal * Satisfy linter * Do not re-generate timestamp in debugger * Update the frontend deparser to support the protojson parsing Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Co-authored-by: Andrea Jiang <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Modify event data using the debugger (consensus-shipyard#533) Added the possibility to modify the logs that each MIR node sends by modifying the incoming message. (For now, only the JSON leaves are modifiable. ) All the JSON types have been taken care of: it's important to notice that once a 'null' field is clicked to modify, it will become a 'string type afterward'. For other types, the type will be preserved if the newly modified value is acceptable for that specific type. For example, inserting 'true' into a boolean field will remain a boolean, but using 'tru' will result in it becoming a string field. Co-authored-by: Andrea Jiang <[email protected]> Disconnecting the debugger (consensus-shipyard#534) * Added 'close connection' button to close the connection to the specific websocket * Decline any current Log when clicking the 'close connection' button Co-authored-by: Andrea Jiang <[email protected]> Async debug mode (consensus-shipyard#535) Add the possibility to automatically accept the incoming logs from the MIR node. Co-authored-by: Andrea Jiang <[email protected]> Describe debugger events (consensus-shipyard#542) Co-authored-by: Andrea Jiang <[email protected]> Latest debugger event on top (consensus-shipyard#543) Co-authored-by: Andrea Jiang <[email protected]> Update debugger log message (consensus-shipyard#544) Co-authored-by: Andrea Jiang <[email protected]> restructure original visualization code
komplexon3
pushed a commit
to komplexon3/mir
that referenced
this pull request
Apr 1, 2024
Generalize and simplify the interceptor Generalize: The interceptor can now interfere with the intercepted events. Instead of returning just an error value, it now also returns an `EventList`. It is those returned events (instead of the input events) that Mir uses for delivering to its modules. Simplify: The `EventRecord`s have been overused in parts of the code where they did not necessarily belong. They are now replaced by simple `EventList`s wherever appropriate. Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Add run.sh to pingpong for convenience Signed-off-by: Matej Pavlovic <[email protected]> Implement WebSocket debugger (consensus-shipyard#528) Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Add Mir debugger frontend (consensus-shipyard#527) Create frontend to connect to MIR nodes to accept or decline new log messages Co-authored-by: Andrea Jiang <[email protected]> Event modification through frontend (consensus-shipyard#541) * added the replace event functionality for the debugger in the backend, using protojson.Marshal instead of json.Marshal * Satisfy linter * Do not re-generate timestamp in debugger * Update the frontend deparser to support the protojson parsing Signed-off-by: Matej Pavlovic <[email protected]> Co-authored-by: Matej Pavlovic <[email protected]> Co-authored-by: Andrea Jiang <[email protected]> Co-authored-by: Schmit Catherine <[email protected]> Modify event data using the debugger (consensus-shipyard#533) Added the possibility to modify the logs that each MIR node sends by modifying the incoming message. (For now, only the JSON leaves are modifiable. ) All the JSON types have been taken care of: it's important to notice that once a 'null' field is clicked to modify, it will become a 'string type afterward'. For other types, the type will be preserved if the newly modified value is acceptable for that specific type. For example, inserting 'true' into a boolean field will remain a boolean, but using 'tru' will result in it becoming a string field. Co-authored-by: Andrea Jiang <[email protected]> Disconnecting the debugger (consensus-shipyard#534) * Added 'close connection' button to close the connection to the specific websocket * Decline any current Log when clicking the 'close connection' button Co-authored-by: Andrea Jiang <[email protected]> Async debug mode (consensus-shipyard#535) Add the possibility to automatically accept the incoming logs from the MIR node. Co-authored-by: Andrea Jiang <[email protected]> Describe debugger events (consensus-shipyard#542) Co-authored-by: Andrea Jiang <[email protected]> Latest debugger event on top (consensus-shipyard#543) Co-authored-by: Andrea Jiang <[email protected]> Update debugger log message (consensus-shipyard#544) Co-authored-by: Andrea Jiang <[email protected]> restructure original visualization code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the functions related to the new interceptor with the basic functionality to accept or decline events. In main.go of the pingpongapplication, I added a few lines to use this interceptor.