modified existing functions to return an EventList for the modified interceptor for visualization #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
force-pushed
the
visualization
branch
2 times, most recently
from
5287f2b to
d88c2f1
Compare
matejpavlovic
suggested changes
Nov 29, 2023
matejpavlovic
approved these changes
Dec 1, 2023
Signed-off-by: Matej Pavlovic <[email protected]>
…ventList and an error
matejpavlovic
force-pushed
the
visualization
branch
from
e6fa802 to
32b1a70
Compare
matejpavlovic
merged commit 1fb845c
into
consensus-shipyard:visualization
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different functions now return an EventList or an EventRecord such that the Events intercepted by the intercepter can also be modified by it.
may want to check my modifications of the implementations of the following to check nothing is broken unintentionally, as I might have overlooked something: