Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): configurable chain id #1230

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feat(node): configurable chain id #1230

merged 4 commits into from
Dec 9, 2024

Conversation

cryptoAtwill
Copy link
Contributor

@cryptoAtwill cryptoAtwill commented Dec 6, 2024 •
edited by raulk
Loading

This PR closes #1229.

It adds chain_id to the Genesis struct. The chain_id passed to tendermint is checked:

  • If chain_id is configured, use the configured value.
  • If not derive from chain_name.

@cryptoAtwill cryptoAtwill requested a review from a team as a code owner December 6, 2024 07:08
cryptoAtwill added 2 commits December 6, 2024 15:20
@raulk raulk merged commit c1c51f7 into main Dec 9, 2024
16 checks passed
@raulk raulk deleted the chain-id-config branch December 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IPC Core Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chain ID customization
2 participants
@cryptoAtwill @raulk