feat: support l2 plus fendermint tests #1177
Conversation
| // Run the command and handle errors | ||
| let output = cmd.output().context("failed to run forge create")?; | ||
|
|
||
| println!("OUT: {}", String::from_utf8_lossy(&output.stdout)); |
There was a problem hiding this comment.
@karlem print stderr in case of failure
| .first() | ||
| .cloned() | ||
| .unwrap_or_else(|| { | ||
| panic!("No node with ethapi_http_endpoint found in the contract deployment config") |
There was a problem hiding this comment.
Do not panic. Return an error
karlem
changed the title
karlem
force-pushed
the
support-l2-plus
branch
from
0d896a7 to
ff75e79
Compare
karlem
force-pushed
the
support-l2-plus-fendermint-tests
branch
from
751c615 to
a8aa488
Compare
karlem
force-pushed
the
support-l2-plus-fendermint-tests
branch
from
a8aa488 to
2f44952
Compare
| @@ -69,7 +69,9 @@ port = 9184 | |||
| enabled = true | |||
|
|
|||
| [tracing.file] | |||
| enabled = false | |||
| enabled = true | |||
There was a problem hiding this comment.
probably we can revert these changes
| import {EMPTY_BYTES, METHOD_SEND} from "../../contracts/constants/Constants.sol"; | ||
|
|
||
| /// This is a simple helper contract for Materializer to test cross messages. | ||
| contract CrossMessenger { |
There was a problem hiding this comment.
@karlem For this contract, is it possible to shift to examples folder? That's where we put sample/custom implementations. This contract is not really part of the protocol, it feels kind of strange to put it here though.
| - name: "cross_messenger" | ||
| deployer: will | ||
| # TODO Karel - allow relative paths | ||
| foundry_root: "/Users/karlem/work/ipc/contracts" |
There was a problem hiding this comment.
this will break in CI?
| solidity_deployments: | ||
| - name: "cross_messenger" | ||
| deployer: will | ||
| foundry_root: "/Users/karlem/work/ipc/contracts" |
| @@ -142,13 +142,21 @@ impl TopDownFinalityQuery for EthSubnetManager { | |||
| topic1, | |||
| ); | |||
|
|
|||
| println!( | |||
There was a problem hiding this comment.
shall we remove the print?
| @@ -60,6 +60,8 @@ fn main() { | |||
| "LibStakingChangeLog", | |||
| "LibGateway", | |||
| "LibQuorum", | |||
| // Materializer TODO Karel - move this elsewhere | |||
| "CrossMessenger", | |||
There was a problem hiding this comment.
This should not be compile as part of the rust binding. It can be shifted to the testing crate, as part of the building script.
Or the other way is just copy the abi over, use abigen! instead, just one contract.
|
|
||
| #[serial_test::serial] | ||
| #[tokio::test] | ||
| async fn test_cross_messages() { |
There was a problem hiding this comment.
It would be very helpful to add some simple description for what the test is about, from reading the code, it's quite difficult to infer.
| println!("Historical Event: {:?}", log); | ||
| } | ||
|
|
||
| // let events = england_gateway_messenger |
There was a problem hiding this comment.
Are these commented code still needed?
karlem
force-pushed
the
support-l2-plus
branch
from
a7c17ee to
e514fdb
Compare
karlem
force-pushed
the
support-l2-plus
branch
from
17344aa to
28209f8
Compare
Part of #1080
End-to-End Testing with Fendermint
Changes and Improvements in Materializer for Testability
L2+ Subnet Deployment Improvements: Deploying L2+ subnets was previously hindered by insufficient wait times for the deployer's balance to be funded during the top-down finalization process. To address this, a
wait_for_balancefunction has been added, which ensures the deployer has a positive balance before proceeding.Custom Contract Deployment for L2+ Testing: Testing L2+ subnets requires deploying custom contracts, such as the IPC handler actor at the destination. Additionally, only smart contracts (not EOAs) are permitted to trigger cross-network messages. To support this, Materializer now includes a
solidity_deploymentsfield in the subnet manifest to enable the deployment of Solidity contracts.Helper Contracts for Testing: Simple helper contracts have been added to the Materializer for testing purposes. These include contracts to trigger cross-net messages and manage IPC handlers at the destination.