Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(node): observability refinements. #1085

Merged
merged 2 commits into from
Jul 23, 2024
Merged

refactor(node): observability refinements. #1085

merged 2 commits into from
Jul 23, 2024

Conversation

raulk
Copy link
Contributor

@raulk raulk commented Jul 23, 2024

  1. Rename Proposals domain to Consensus.
  2. Change block proposal metrics to gauges representing the last height. Using the height as a label value is problematic, as its unbounded.
  3. Adjust docs, specs, changelog. Change some lists to tables + minor edits.

@raulk
refactor(node): observability refinements.
0e54d53 
1. Rename `Proposals` domain to `Consensus`.
2. Change block proposal metrics to gauges representing the last
   height. Using the height as a label value is problematic, as its
   unbounded.
3. Adjust docs, specs, changelog. Change some lists to tables + minor edits.
@raulk raulk requested a review from karlem July 23, 2024 11:30
@raulk raulk merged commit 245d65e into main Jul 23, 2024
19 checks passed
@raulk raulk deleted the raulk/observability-refinements branch July 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlem karlem karlem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IPC Core Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @karlem