Skip to content

Commit

Permalink
Update dependencies & Go (#48)
Browse files Browse the repository at this point in the history
- Update command-line build tools
- Update Go for CI
- Rename unused parameter
  • Loading branch information
akshayjshah authored May 15, 2023
1 parent 609282a commit 2c0bd17
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [1.18.x,1.19.x]
go-version: [1.19.x, 1.20.x]
steps:
- name: Checkout Code
uses: actions/checkout@v3
Expand All @@ -36,5 +36,5 @@ jobs:
- name: Lint
# Often, lint & gofmt guidelines depend on the Go version. To prevent
# conflicting guidance, run only on the most recent supported version.
if: matrix.go-version == '1.19.x'
if: matrix.go-version == '1.20.x'
run: make checkgenerate && make lint
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ checkgenerate:

$(BIN)/buf: Makefile
@mkdir -p $(@D)
GOBIN=$(abspath $(@D)) $(GO) install github.com/bufbuild/buf/cmd/buf@v1.14.0
GOBIN=$(abspath $(@D)) $(GO) install github.com/bufbuild/buf/cmd/buf@v1.17.0

$(BIN)/license-header: Makefile
@mkdir -p $(@D)
Expand All @@ -84,8 +84,8 @@ $(BIN)/license-header: Makefile

$(BIN)/golangci-lint: Makefile
@mkdir -p $(@D)
GOBIN=$(abspath $(@D)) $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.0
GOBIN=$(abspath $(@D)) $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2

$(BIN)/protoc-gen-go: Makefile
@mkdir -p $(@D)
GOBIN=$(abspath $(@D)) $(GO) install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1
GOBIN=$(abspath $(@D)) $(GO) install google.golang.org/protobuf/cmd/protoc-gen-go@v1.30.0
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module connectrpc.com/grpchealth

go 1.18
go 1.19

require (
connectrpc.com/connect v1.5.1
Expand Down
2 changes: 1 addition & 1 deletion grpchealth.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (c *StaticChecker) SetStatus(service string, status Status) {
}

// Check implements Checker. It's safe to call concurrently with SetStatus.
func (c *StaticChecker) Check(ctx context.Context, req *CheckRequest) (*CheckResponse, error) {
func (c *StaticChecker) Check(_ context.Context, req *CheckRequest) (*CheckResponse, error) {
if req.Service == "" {
return &CheckResponse{Status: StatusServing}, nil
}
Expand Down
2 changes: 1 addition & 1 deletion internal/gen/go/connectext/grpc/health/v1/health.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2c0bd17

Please sign in to comment.