FEAT: MatchList 컴포넌트에서 데이터를 가져와서 뿌리는 함수 작업. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetchList 함수를 통해 데이터를 가져오고, useEffect, usestate로 상태 관리하도록 설정.
eastgerm
reviewed
Nov 26, 2019
Comment on lines
+45
to
+51
| key={match.seq} | ||
| hostSeq={match.host.seq} | ||
| hostName={match.host.seq} | ||
| stadium={match.stadium} | ||
| date={match.date} | ||
| startTime={match.startTime} | ||
| endTime={match.endTime} |
There was a problem hiding this comment.
props로 match만 보내는 방법은 어떨까요?
(key 제외)
eastgerm
reviewed
Nov 26, 2019
Comment on lines
+9
to
+23
| const gqlQuery = { | ||
| query: `{ | ||
| PendingMatches{ | ||
| seq | ||
| host{ | ||
| seq | ||
| name | ||
| } | ||
| stadium | ||
| date | ||
| startTime | ||
| endTime | ||
| } | ||
| }` | ||
| }; |
There was a problem hiding this comment.
우리도 이렇게 섹시한 쿼리를 사용할 수 있다니.. 옹기갓
eastgerm
reviewed
Nov 26, 2019
| import { Button } from '../../common'; | ||
| import './index.scss'; | ||
|
|
||
| const MatchList = () => { | ||
|
|
samrho
approved these changes
Nov 26, 2019
Comment on lines
+26
to
+33
| const data = await fetch('http://localhost:4000/graphql',{ | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json' | ||
| }, | ||
| body: JSON.stringify(gqlQuery) | ||
| }); | ||
| const result = await data.json(); |
There was a problem hiding this comment.
util로 이 부분을 박아 놓으면 추후에 중복 제거하는 데에 좋을 것 같습니다.
There was a problem hiding this comment.
async processQuery(gqlQuery) {
// ...
return await data.json();
}어차피 똑같은 주소에 method, headers 다 똑같을 것 같은데 요런 느낌?
jongnan
reviewed
Nov 26, 2019
|
|
||
| const [ matchList, setMatchList ] = useState([]); | ||
|
|
||
| const gqlQuery = { |
There was a problem hiding this comment.
나중에 쿼리가 많아지면 따로 관리해야 될 것 같습니다!
There was a problem hiding this comment.
gqlQuery가 아닌 매치 리스트들을 가져오는거니깐 GET_MATCH_LIST_QUERY ? 요런식으로 네이밍하는것도 좋을 것 같습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchList 함수를 통해 데이터를 가져오고, useEffect, usestate로 상태 관리하도록 설정.
관련 이슈
개발 내용 요약