Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up generated message classes #923

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Clean up generated message classes #923

merged 2 commits into from
Jan 3, 2025

Conversation

gbirchmeier
Copy link
Member

@gbirchmeier gbirchmeier commented Jan 3, 2025 •
edited
Loading

The last PR needed to close #921

  • rename/deprecate a fieldOrder variable in generated message classes, which violates C# naming conventions
  • reduce code size and unnecessary empty lines (by a lot)

@mgatny mgatny merged commit d4645a7 into connamara:master Jan 3, 2025
2 checks passed
@gbirchmeier gbirchmeier deleted the better-gen-messages branch January 3, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgatny mgatny mgatny approved these changes

@SNORRIS721 SNORRIS721 Awaiting requested review from SNORRIS721

@hlibman-connamara hlibman-connamara Awaiting requested review from hlibman-connamara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up generated code
2 participants
@gbirchmeier @mgatny