(#742 rebase/squash) Improvements to HTTP web proxy #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirchmeier
force-pushed
the
pr742-IanLeeClaxton-improve-http-proxy
branch
from
8b1f6ab to
6828787
Compare
Bug: proxy connect packet is malformed due to a space after HTTP/1.1. Feature: Pass the host name so proxy host acls can be matched. Feature: Switch to the WebRequest.DefaultWebProxy which allows for overriding in app.settings file and falls back to the system proxy if not configured. Improvement: Use ordinal comparision for IndexOf on the proxy response. Resolves connamara#742 (original PR, this is a rebase)
gbirchmeier
force-pushed
the
pr742-IanLeeClaxton-improve-http-proxy
branch
from
6828787 to
08ddad1
Compare
gbirchmeier
added a commit
that referenced
this pull request
Dec 30, 2024
hlibman-connamara
approved these changes
Dec 30, 2024
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Dec 31, 2024
accidentally introduced in PR connamara#917, somehow I overlooked the warning
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Dec 31, 2024
accidentally introduced in PR connamara#917, somehow I overlooked the warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iclaxton 's original comment from PR #742:
Resolves #742 (original PR, this is a rebase)