(squash/update of #909) Read message type from fix string without regex #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirchmeier
force-pushed
the
rebase-909-msg-type-without-regex
branch
from
e73ae6c to
7521b48
Compare
BenchmarkDotNet v0.14.0, NixOS 24.11 (Vicuna)
11th Gen Intel Core i7-1165G7 2.80GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.307
[Host] : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
DefaultJob : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|------- |----------:|---------:|----------:|-------:|----------:|
| Manual | 35.33 ns | 2.754 ns | 8.122 ns | 0.0038 | 24 B |
| Regex | 322.38 ns | 9.405 ns | 25.265 ns | 0.0648 | 408 B |
gbirchmeier
force-pushed
the
rebase-909-msg-type-without-regex
branch
from
7521b48 to
ee47ce9
Compare
hlibman-connamara
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #909 -- this PR is the same content, squashed into one commit, plus release notes and a little cleanup
attn @jkulubya
Original description from #909:
I'm investigating how to have the message type as part of the log's context when a message is sent/received in #899, and that might require calling GetMsgType on the hot path. This pr removes the regex from that method, in case that's the way forward.
Manual is this PR, Regex is current code.