delete "#nullable enable" from QuickFIX proj files

connamara · Sep 25, 2024 · 8d14aa6 · 8d14aa6
1 parent b6ab1b5
commit 8d14aa6
Show file tree

Hide file tree

Showing 43 changed files with 34 additions and 87 deletions.
diff --git a/QuickFIXn/AbstractInitiator.cs b/QuickFIXn/AbstractInitiator.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Threading;
+using System.Threading;
 using System.Collections.Generic;
 using System;
 using QuickFix.Logger;

diff --git a/QuickFIXn/AcceptorSocketDescriptor.cs b/QuickFIXn/AcceptorSocketDescriptor.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System.Collections.Generic;
 using System.Net;
 using QuickFix.Logger;

diff --git a/QuickFIXn/ClientHandlerThread.cs b/QuickFIXn/ClientHandlerThread.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Net.Sockets;
+using System.Net.Sockets;
 using System.Threading;
 using System;
 using QuickFix.Logger;

diff --git a/QuickFIXn/DefaultMessageFactory.cs b/QuickFIXn/DefaultMessageFactory.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

diff --git a/QuickFIXn/Fields/Converters/DateTimeConverter.cs b/QuickFIXn/Fields/Converters/DateTimeConverter.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.Globalization;
 

diff --git a/QuickFIXn/Fields/IField.cs b/QuickFIXn/Fields/IField.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 
 namespace QuickFix.Fields
 {

diff --git a/QuickFIXn/HttpServer.cs b/QuickFIXn/HttpServer.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

diff --git a/QuickFIXn/Logger/CompositeLog.cs b/QuickFIXn/Logger/CompositeLog.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 
 namespace QuickFix.Logger;
 

diff --git a/QuickFIXn/Logger/CompositeLogFactory.cs b/QuickFIXn/Logger/CompositeLogFactory.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Linq;
+using System.Linq;
 
 namespace QuickFix.Logger;
 

diff --git a/QuickFIXn/Logger/FileLog.cs b/QuickFIXn/Logger/FileLog.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using QuickFix.Fields.Converters;
 using QuickFix.Util;
 

diff --git a/QuickFIXn/Logger/FileLogFactory.cs b/QuickFIXn/Logger/FileLogFactory.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Logger;
+namespace QuickFix.Logger;
 
 /// <summary>
 /// Creates a message store that stores messages in a file

diff --git a/QuickFIXn/Logger/ILogFactory.cs b/QuickFIXn/Logger/ILogFactory.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Logger;
+namespace QuickFix.Logger;
 
 /// <summary>
 /// Creates a log instance

diff --git a/QuickFIXn/Logger/NonSessionLog.cs b/QuickFIXn/Logger/NonSessionLog.cs
@@ -1,6 +1,3 @@
-#nullable enable
-using System;
-
 namespace QuickFix.Logger;
 
 /// <summary>

diff --git a/QuickFIXn/Logger/NullLogFactory.cs b/QuickFIXn/Logger/NullLogFactory.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Logger;
+namespace QuickFix.Logger;
 
 public class NullLogFactory : ILogFactory
 {

diff --git a/QuickFIXn/Logger/ScreenLog.cs b/QuickFIXn/Logger/ScreenLog.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Logger;
+namespace QuickFix.Logger;
 
 /// <summary>
 /// FIXME - needs to log sessionIDs, timestamps, etc.

diff --git a/QuickFIXn/Logger/ScreenLogFactory.cs b/QuickFIXn/Logger/ScreenLogFactory.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Logger;
+namespace QuickFix.Logger;
 
 public class ScreenLogFactory : ILogFactory
 {

diff --git a/QuickFIXn/Message/FieldMap.cs b/QuickFIXn/Message/FieldMap.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;

diff --git a/QuickFIXn/Message/FieldNotFoundException.cs b/QuickFIXn/Message/FieldNotFoundException.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 
 namespace QuickFix
 {

diff --git a/QuickFIXn/Message/Group.cs b/QuickFIXn/Message/Group.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Text;
 
 namespace QuickFix

diff --git a/QuickFIXn/Message/Header.cs b/QuickFIXn/Message/Header.cs
@@ -1,5 +1,3 @@
-#nullable enable
-using System;
 using System.Text;
 using QuickFix.Fields;
 

diff --git a/QuickFIXn/Message/Message.cs b/QuickFIXn/Message/Message.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Text;
 using QuickFix.Fields;
 using System.Text.RegularExpressions;

diff --git a/QuickFIXn/Message/Trailer.cs b/QuickFIXn/Message/Trailer.cs
@@ -1,5 +1,3 @@
-#nullable enable
-using System;
 using System.Text;
 using QuickFix.Fields;
 

diff --git a/QuickFIXn/MessageBuilder.cs b/QuickFIXn/MessageBuilder.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix
+namespace QuickFix
 {
     internal class MessageBuilder
     {

diff --git a/QuickFIXn/Session.cs b/QuickFIXn/Session.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Threading;

diff --git a/QuickFIXn/SessionFactory.cs b/QuickFIXn/SessionFactory.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using QuickFix.Logger;
 using QuickFix.Store;

diff --git a/QuickFIXn/SessionID.cs b/QuickFIXn/SessionID.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 
 namespace QuickFix
 {

diff --git a/QuickFIXn/SessionSchedule.cs b/QuickFIXn/SessionSchedule.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 
 namespace QuickFix

diff --git a/QuickFIXn/SessionState.cs b/QuickFIXn/SessionState.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System;
 using System.Collections.Generic;
 using QuickFix.Logger;

diff --git a/QuickFIXn/Settings.cs b/QuickFIXn/Settings.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Collections.Generic;
+using System.Collections.Generic;
 
 namespace QuickFix
 {

diff --git a/QuickFIXn/SettingsDictionary.cs b/QuickFIXn/SettingsDictionary.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using QuickFix.Fields.Converters;

diff --git a/QuickFIXn/SocketInitiatorThread.cs b/QuickFIXn/SocketInitiatorThread.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Diagnostics;
 using System.IO;
 using System.Net;

diff --git a/QuickFIXn/SocketReader.cs b/QuickFIXn/SocketReader.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Net.Sockets;
+using System.Net.Sockets;
 using System.IO;
 using System;
 using System.Linq;

diff --git a/QuickFIXn/Store/FileStore.cs b/QuickFIXn/Store/FileStore.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.Text;
 using QuickFix.Util;

diff --git a/QuickFIXn/Store/FileStoreFactory.cs b/QuickFIXn/Store/FileStoreFactory.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-namespace QuickFix.Store;
+namespace QuickFix.Store;
 
 /// <summary>
 /// Creates a message store that stores messages in a file

diff --git a/QuickFIXn/Store/MemoryStore.cs b/QuickFIXn/Store/MemoryStore.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 
 namespace QuickFix.Store;

diff --git a/QuickFIXn/ThreadedSocketAcceptor.cs b/QuickFIXn/ThreadedSocketAcceptor.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using System.Net;
 using System;

diff --git a/QuickFIXn/ThreadedSocketReactor.cs b/QuickFIXn/ThreadedSocketReactor.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Net;
 using System.Net.Sockets;
 using System.Threading;

diff --git a/QuickFIXn/Transport/SocketInitiator.cs b/QuickFIXn/Transport/SocketInitiator.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

diff --git a/QuickFIXn/Transport/SslCertCache.cs b/QuickFIXn/Transport/SslCertCache.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System;
 using System.Collections.Generic;
 using System.IO;

diff --git a/QuickFIXn/Transport/SslStreamFactory.cs b/QuickFIXn/Transport/SslStreamFactory.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System;
 using System.Diagnostics;
 using System.IO;

diff --git a/QuickFIXn/Transport/StreamFactory.cs b/QuickFIXn/Transport/StreamFactory.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using System.IO;
 using System.Linq;
 using System.Net;

diff --git a/QuickFIXn/Util/StringUtil.cs b/QuickFIXn/Util/StringUtil.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System.Runtime.InteropServices;
 
 namespace QuickFix.Util

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -35,7 +35,7 @@ What's New
          finishes loading all the dlls (gbirchmeier, with thanks to diagnosis by Brian Leach aka baffled)
          (Note: this may be the cause of spurious "incorrect BeginString" issues that have been observed)
 * #877 - throw an exception if Message.ToJSON(dd=null,convertEnumsToDescriptions=true) is called (gbirchmeier)
-* #TBD - cleanup/nullable-ize IField-derived classes (gbirchmeier)
+* #888 - cleanup/nullable-ize IField-derived classes (gbirchmeier)
      * deprecate lower-case-starting function names (renamed to upper-case-starting)
      * deprecate <Foo>Field.Obj (renamed to Value)
      * deprecate <Foo>Field.getValue/setValue (just use Value getter/setter)