CC-29764 Add timeout to sink put cycle #801
Merged
+85
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
sp-gupta
reviewed
Nov 29, 2024
| } | ||
|
|
||
| private void resume() { | ||
| log.trace("Resuming writer for topic-partition '{}'", tp); | ||
| context.resume(tp); | ||
| isPaused = true; |
There was a problem hiding this comment.
Thanks for pointing out. I have fixed it
sp-gupta
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds a time out to the put loop to add a limit on maximum amount of time a task can spend in the poll cycle
If the task spends significant amount of time in poll loop, it will likely become a zombie.
Hence, adding a timeout can prevent a zombie task from processing the files
Solution
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Manually tested by adding random sleep in the task and ensuring that the task reaches deadline in such cases
Release Plan