Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Add metric -- count of queries waiting for merge buffers" … #223

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

hardikbajaj
Copy link
Member

Add 'mergeBuffer/pendingRequests' metric that exposes the count of waiting queries (threads) blocking in the merge buffers pools.

  • Update addMetric to build

Backports: apache#15025
Only change

emitter.emit(builder.setMetric("mergeBuffer/pendingRequests", pendingQueries));  --> 
emitter.emit(builder.build("mergeBuffer/pendingRequests", pendingQueries));

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

)

* Add metric -- count of queries waiting for merge buffers (apache#15025)

Add 'mergeBuffer/pendingRequests' metric that exposes the count of waiting queries (threads) blocking in the merge buffers pools.

* Update addMetric to build

---------

Co-authored-by: kaisun2000 <[email protected]>
@hardikbajaj hardikbajaj requested a review from a team as a code owner September 4, 2024 08:36
Copy link

@pagrawal10 pagrawal10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hardikbajaj hardikbajaj merged commit 90f60f7 into 25.0.0-confluent Sep 4, 2024
2 checks passed
@hardikbajaj hardikbajaj deleted the hardik-devel branch September 4, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants