Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod in kafka directory #1323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

acgtun
Copy link

@acgtun acgtun commented Oct 27, 2024

Add modular in kafka directory, so that we could import only kafka modular without the other modulars.

@acgtun acgtun requested review from a team as code owners October 27, 2024 21:29
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ acgtun
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@milindl
Copy link
Contributor

milindl commented Oct 28, 2024

Hi @acgtun , I think this idea is worth looking into in more details and separate other modules (schemaregistry) but at the current time, I think this will break backwards compatibility by requiring every user to change their import statements (v2/kafka changes to kafka/v2). So we can't merge this immediately.
I'll discuss this internally to see if this is something we do with our next major version upgrade whenever it is planned.

@acgtun
Copy link
Author

acgtun commented Oct 28, 2024

Thanks @milindl for looking into it.

@acgtun
Copy link
Author

acgtun commented Oct 29, 2024

Hi @milindl, for us, the main reason we want to create a kafka modular is to reduce some of the dependency requirements.
for example, github.com/docker/docker , k8s.io/cri, etc, these that are not used in kafka modular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants