Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return more clearly topic error message #1162

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

return more clearly topic error message #1162

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
861efe0
return more clearly topic error message
darrkz Apr 1, 2024
1a1b1cc
change error detect
darrkz Apr 17, 2024
2e4b4b8
Merge branch 'master' into patch-1
darrkz Apr 18, 2024
b7c1280
Merge branch 'master' into patch-1
darrkz Apr 22, 2024
b7d011b
Merge branch 'master' into patch-1
darrkz May 7, 2024
d842be0
format commit
darrkz May 7, 2024
3e4d5c0
Merge branch 'master' into patch-1
darrkz May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kafka/producer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,10 @@ func (p *Producer) gethandle() *handle {
}

func (p *Producer) produce(msg *Message, msgFlags int, deliveryChan chan Event) error {
if msg == nil || msg.TopicPartition.Topic == nil || len(*msg.TopicPartition.Topic) == 0 {
if msg == nil || len(*msg.TopicPartition.Topic) == 0 {
return newErrorFromString(ErrInvalidArg, "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if msg == nil || len(*msg.TopicPartition.Topic) == 0 {
return newErrorFromString(ErrInvalidArg, "")
if msg == nil {
return newErrorFromString(ErrInvalidArg, "msg cannot be nil")

}else if msg.TopicPartition.Topic == nil{
return newErrorFromString(ErrUnknownTopic, "topic is null, please check")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}else if msg.TopicPartition.Topic == nil{
return newErrorFromString(ErrUnknownTopic, "topic is null, please check")
} else if msg.TopicPartition.Topic == nil || len(*msg.TopicPartition.Topic) == 0 {
return newErrorFromString(ErrInvalidArg, "topic cannot be nil or empty")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must keep in mind, 2 things,

  1. msg.TopicPartition.Topic == nil must be made before len(*msg.TopicPartition.Topic) == 0 , else it causes a nil pointer dereference and will panic.
  2. We can't change the type of the error, only the message of it (since the type is a part of the public API so people might be relying on that)

}

crkt := p.handle.getRkt(*msg.TopicPartition.Topic)
Expand Down