Run gofmt 1.19; Fix bundle-import.sh to generate correct output #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.19 introduced gofmt formatting changes. This change runs gofmt from Go 1.19, since commit 09f2d70 on 2023-07-14 updated to use that version. It also fixes bundle-import.sh to generate the correct output. The changes are: * Add the new "//go:build" format lines * Put "// +build" tags on one line * Ensure the correct number of newlines With these changes, future runs of bundle-import.sh should generate output that is not changed by running gofmt, with one exception: The libs line for Windows has a \r\n line ending, since it comes from the pkg-config .pc file which has \r\n line endings. I have left this unmodified. kafka/README.md: Update link to correct location See Go 1.19 release notes for details about gofmt changes: https://tip.golang.org/doc/go1.19#go-doc
|
Thanks for this PR! |
|
I'll merge #1136 first, and then, this. It updates the go version (both the supported and development versions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.19 introduced gofmt formatting changes. This change runs gofmt from Go 1.19, since commit 09f2d70 on 2023-07-14 updated to use that version. It also fixes bundle-import.sh to generate the correct output. The changes are:
With these changes, future runs of bundle-import.sh should generate output that is not changed by running gofmt, with one exception: The libs line for Windows has a \r\n line ending, since it comes from the pkg-config .pc file which has \r\n line endings. I have left this unmodified.
kafka/README.md: Update link to correct locationSee Go 1.19 release notes for details about gofmt changes: https://tip.golang.org/doc/go1.19#go-doc