Skip to content

Commit

Permalink
Bump librdkafka requirement to 1.3.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
rigelbm committed Dec 16, 2019
1 parent 531a955 commit 53193a4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Getting Started
Installing librdkafka
---------------------

This client for Go depends on librdkafka v1.1.0 or later, so you either need to install librdkafka
This client for Go depends on librdkafka v1.3.0 or later, so you either need to install librdkafka
through your OS/distributions package manager, or download and build it from source.

- For Debian and Ubuntu based distros, install `librdkafka-dev` from the standard
Expand Down
10 changes: 5 additions & 5 deletions kafka/00version.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@ import (
//defines and strings in sync.
//
#define MIN_RD_KAFKA_VERSION 0x01010000
#define MIN_RD_KAFKA_VERSION 0x010300ff
#ifdef __APPLE__
#define MIN_VER_ERRSTR "confluent-kafka-go requires librdkafka v1.1.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
#define MIN_VER_ERRSTR "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
#else
#define MIN_VER_ERRSTR "confluent-kafka-go requires librdkafka v1.1.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"
#define MIN_VER_ERRSTR "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"
#endif
#if RD_KAFKA_VERSION < MIN_RD_KAFKA_VERSION
#ifdef __APPLE__
#error "confluent-kafka-go requires librdkafka v1.1.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
#error "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
#else
#error "confluent-kafka-go requires librdkafka v1.1.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"
#error "confluent-kafka-go requires librdkafka v1.3.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html"
#endif
#endif
*/
Expand Down
6 changes: 3 additions & 3 deletions kafka/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ For each release candidate and final release, perform the following steps:
Make sure the librdkafka version installed is the version this release
is aimed to be used with.

E.g., confluent-kafka-go v1.0.0 will require librdkafka v1.0.0.
E.g., confluent-kafka-go v1.3.0 will require librdkafka v1.3.0.


### Update librdkafka version requirement
Expand Down Expand Up @@ -135,8 +135,8 @@ Make sure to push to github before creating the tag to have CI tests pass.

### Create and push tag

$ git tag v1.0.0-RC3
$ git push --dry-run origin v1.0.0-RC3
$ git tag v1.3.0
$ git push --dry-run origin v1.3.0
# Remove --dry-run and re-execute if it looks ok.


Expand Down
2 changes: 1 addition & 1 deletion kafka/generated_errors.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package kafka
// Copyright 2016 Confluent Inc.
// AUTOMATICALLY GENERATED BY /home/rigelbm/go/bin/go_rdkafka_generr ON 2019-12-16 14:58:01.981501545 +0000 GMT m=+0.000088928 USING librdkafka 1.3.0
// AUTOMATICALLY GENERATED BY /home/rigelbm/go/bin/go_rdkafka_generr ON 2019-12-16 15:26:26.707334298 +0000 GMT m=+0.000085505 USING librdkafka 1.3.0

/*
#include <librdkafka/rdkafka.h>
Expand Down

0 comments on commit 53193a4

Please sign in to comment.