Add 2 new option arguments for BW, 'topics' and 'schemas', If set, BW will only snapshot/streaming these 'topics' in these 'schemas', 'topics' and 'schemas' are vertical-line separated list. #101
Conversation
…ointer to another place
|
Sorry, I've just added this commit to my branch, so it will be on this PR. Are you ok with this ? 😟 |
…tency with others when parsing options in logdecoder.c
…order by specified column
…heck order column
There was a problem hiding this comment.
@badboyd sorry for leaving this hanging for so long. I'm no longer working actively on Bottled Water and I've been busy with other projects.
Thanks for all your changes. The default behaviour still isn't quite right, but we're almost there!
Regarding the VARATT_IS_EXTERNAL_ONDISK commit, did you find it fixed the problem you described in #113? So long as it does actually fix #113 then I think it's okay to include it in this PR. (It's better in general if you can do pull requests from a separate branch, so that you can keep working on your fork's master while the pull request is waiting to be merged, but I don't want to ask you to reshuffle your commits when you've already spent so much time on this :))
| @@ -432,6 +432,12 @@ int snapshot_tuple(client_context_t context, PGresult *res, int row_number) { | |||
| /* Lookup for table oids from schema_pattern and table_pattern | |||
| If schema_pattern == % and table_pattern == % then BW will get all tables in db */ | |||
| int lookup_table_oids(client_context_t context) { | |||
|
|
|||
| if (strcmp(context->table_pattern, "%%") == 0 && strcmp(context->schema_pattern, "%%") == 0) { | |||
There was a problem hiding this comment.
Thanks for restoring this check, but I still think we should use "" (the empty string) as the default (i.e. strcmp(..., "")), rather than "%%". As I described in this comment, using "%%" as the default means we have confusing behaviour if someone explicitly specifies --tables=%%.
|
Just wanted to say thanks for the time that both of you — @samstokes and @badboyd — have put into this! I'm keenly interested in seeing this PR land. I'm not sure what the protocol is for this repo, but I'm happy to contribute some time as a reviewer or developer to assist, if that helps. |
Add a clearer log for unknown config.
|
Any updates on this PR? |
No description provided.