Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install prettier #43

Closed
wants to merge 6 commits into from
Closed

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 2, 2024

stylelint is not much of a formatting tool any more.

And remove npx https://docs.npmjs.com/cli/v10/using-npm/scripts

Copy link

netlify bot commented May 2, 2024

‼️ Deploy request for sprucecss rejected.

Name Link
🔨 Latest commit 90c64c0

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 2, 2024

Destroys Adam's art

https://prettier.io/docs/en/options

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 2, 2024

So does stylelint still care about formatting??

src/scss/component/_theme-switcher.scss
  11:3  ✖  Expected empty line before rule  rule-empty-line-before
  14:3  ✖  Expected empty line before rule  rule-empty-line-before

in node_modules/stylelint/lib/rules/at-rule-empty-line-before/index.mjs

@szepeviktor
Copy link
Contributor Author

What to do now??

@adamlaki
Copy link
Member

adamlaki commented May 7, 2024

Nice job Viktor!

I still don't know much about Prettier, but I will test this config in my local environment.

@adamlaki
Copy link
Member

adamlaki commented May 7, 2024

Can you help me with npx? If we don't need it, what is its original purpose?

@szepeviktor
Copy link
Contributor Author

Can you help me with npx?

Here it is.

If you depend on modules that define executable scripts, like test suites, then those executables will be added to the PATH for executing the scripts.

https://docs.npmjs.com/cli/v10/using-npm/scripts#path

So npx is not necessary.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 7, 2024

what is its original purpose?

On the command line ./node-modules/.bin/ is not on PATH, so we need npx.

@szepeviktor szepeviktor marked this pull request as ready for review May 7, 2024 16:46
@adamlaki
Copy link
Member

In the Eleventy project, the default install uses npx, hence its presence.

@szepeviktor
Copy link
Contributor Author

Az Ádám 💟 Prettier szerelem már kivirágzott, de a házasság még várat magára.

@szepeviktor szepeviktor closed this Jan 1, 2025
@adamlaki
Copy link
Member

adamlaki commented Jan 3, 2025

Igen, meg úgy fest továbbra is működik az order a jelenlegi setupban.

@szepeviktor
Copy link
Contributor Author

Ezekből arra következtetek, hogy az a bájtszintű izé, amit csinálok, arra a legtöbbeknek nincs ideje.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants