Give a try to (semi)standard

conedevelopment · Aug 21, 2024 · 9b429e6 · 9b429e6
1 parent 384dd72
commit 9b429e6
Show file tree

Hide file tree

Showing 10 changed files with 1,788 additions and 69 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -4,6 +4,8 @@
     "eleventy:serve": "npx eleventy --serve",
     "eleventy:build": "npx eleventy",
     "build": "npm-run-all dist:delete sass:compile eleventy:build",
+    "js:lint": "semistandard src/js/*.js",
+    "js:fix": "semistandard src/js/*.js --fix",
     "sass:watch": "sass --watch --update --load-path=node_modules --no-source-map --style=expanded src/scss:src/css",
     "sass:fix": "stylelint src/scss/**/*.scss --fix",
     "sass:lint": "stylelint src/scss/**/*.scss",
@@ -28,6 +30,7 @@
     "sass": "^1.77.8",
     "slugify": "^1.6.6",
     "sprucecss": "^2.3.3",
+    "semistandard": "^17.0.0",
     "stylelint": "^16.8.2",
     "stylelint-config-sass-guidelines": "^12.0.0",
     "stylelint-order": "^6.0.4"

diff --git a/src/js/cookie-consent.js b/src/js/cookie-consent.js
@@ -1,5 +1,5 @@
 import {
-  setCookie, getCookie, issetCookie, removeCookie,
+  setCookie, getCookie, issetCookie, removeCookie
 } from './cookie.js';
 
 (() => {
@@ -10,8 +10,8 @@ import {
   let redirect = false;
 
   if (
-    !issetCookie(`${prefix}-cookie-law-analytics`)
-    && !issetCookie(`${prefix}-cookie-law-denied`)
+    !issetCookie(`${prefix}-cookie-law-analytics`) &&
+    !issetCookie(`${prefix}-cookie-law-denied`)
   ) {
     caption = `<div class="cookie-consent-helper"><div class="cookie-consent cookie-consent--slidein" tabindex="-1">
         <div class="cookie-consent__caption">This site use cookies. For more information please visit our <a href="/privacy-policy/">privacy policy</a> page.</div>
@@ -26,7 +26,7 @@ import {
     consentModal.focus();
   }
 
-  function animationEndCallback() {
+  function animationEndCallback () {
     consentModal.removeEventListener('animationend', animationEndCallback);
 
     if (redirect) {
@@ -36,8 +36,8 @@ import {
 
   document.addEventListener('click', (e) => {
     if (
-      e.target
-      && e.target.getAttribute('data-action') === 'cookie-accept'
+      e.target &&
+      e.target.getAttribute('data-action') === 'cookie-accept'
     ) {
       setCookie(`${prefix}-cookie-law-analytics`, 'accepted', 365);
 
@@ -47,8 +47,8 @@ import {
     }
 
     if (
-      e.target
-      && e.target.getAttribute('data-action') === 'cookie-decline'
+      e.target &&
+      e.target.getAttribute('data-action') === 'cookie-decline'
     ) {
       setCookie(`${prefix}-cookie-law-denied`, 'true');
 
@@ -60,8 +60,8 @@ import {
 
   btns.forEach((btn) => {
     if (
-      issetCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`)
-      && getCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) === 'accepted'
+      issetCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) &&
+      getCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) === 'accepted'
     ) {
       btn.innerHTML = `${btn.getAttribute('data-on-text')} ${btn.innerHTML}`;
     } else {
@@ -70,8 +70,8 @@ import {
 
     btn.addEventListener('click', () => {
       if (
-        issetCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`)
-        && getCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) === 'accepted'
+        issetCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) &&
+        getCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`) === 'accepted'
       ) {
         removeCookie(`${prefix}-cookie-law-${btn.getAttribute('data-type')}`);
       } else {

diff --git a/src/js/cookie.js b/src/js/cookie.js
@@ -8,19 +8,21 @@
  * @param  {object}  options
  * @return {void}
  */
-export function setCookie(key, value, expires = null, path = '/', options = {}) {
+export function setCookie (key, value, expires = null, path = '/', options = {}) {
   const defaults = {
     [key]: value,
     expires,
     path,
     SameSite: 'Lax',
-    Secure: true,
+    Secure: true
   };
 
   const pairs = { ...defaults, ...options };
 
-  pairs.expires = pairs.expires ? new Date(Date.now() + 86400 * 1000 * pairs.expires)
-    .toUTCString() : null;
+  pairs.expires = pairs.expires
+    ? new Date(Date.now() + 86400 * 1000 * pairs.expires)
+      .toUTCString()
+    : null;
 
   document.cookie = Object.entries(pairs)
     .reduce((stack, entry) => stack.concat(entry.join('=')), [])
@@ -33,7 +35,7 @@ export function setCookie(key, value, expires = null, path = '/', options = {})
  * @param  {string}  key
  * @return {mixed}
  */
-export function getCookie(key) {
+export function getCookie (key) {
   const cookie = document.cookie.match(new RegExp(`(^| )${key}=([^;]+)`));
 
   return (cookie && cookie[2]) ? cookie[2] : null;
@@ -45,7 +47,7 @@ export function getCookie(key) {
  * @param  {string}  key
  * @return {bool}
  */
-export function issetCookie(key) {
+export function issetCookie (key) {
   return document.cookie.match(new RegExp(`(^| )${key}=([^;]+)`)) !== null;
 }
 
@@ -55,6 +57,6 @@ export function issetCookie(key) {
  * @param  {string}  key
  * @return {void}
  */
-export function removeCookie(key) {
+export function removeCookie (key) {
   setCookie(key, null, 'Thu, 01 Jan 1970 00:00:01 GMT');
 }
diff --git a/src/js/modal.js b/src/js/modal.js
@@ -7,20 +7,20 @@
 
   if (!buttons || !modal) return;
 
-  function openModal() {
+  function openModal () {
     activeElement = document.activeElement;
     siteWrapper.setAttribute('inert', '');
     modal.classList.add('modal-backdrop--open');
     input.focus();
   }
 
-  function closeModal() {
+  function closeModal () {
     siteWrapper.removeAttribute('inert');
     modal.classList.remove('modal-backdrop--open');
     activeElement.focus();
   }
 
-  function handleKeyDown(e) {
+  function handleKeyDown (e) {
     if (e.code === 'Escape') {
       closeModal();
     }

diff --git a/src/js/navigation.js b/src/js/navigation.js
@@ -1,3 +1,5 @@
+/* global getComputedStyle */
+
 (() => {
   const header = document.querySelector('.site-header');
   const navigation = document.querySelector('.site-navigation');
@@ -7,7 +9,7 @@
 
   if (!menu || typeof button === 'undefined') return;
 
-  function widthChange(query) {
+  function widthChange (query) {
     button.setAttribute('aria-expanded', !query.matches);
   }
 

diff --git a/src/js/scripts.js b/src/js/scripts.js
@@ -1,5 +1,5 @@
 import {
-  getCookie,
+  getCookie
 } from './cookie.js';
 
 if (getCookie('spruce-cookie-law-analytics') === 'accepted') {
@@ -19,6 +19,6 @@ if (getCookie('spruce-cookie-law-analytics') === 'accepted') {
   gtag('js', new Date());
   gtag('config', spruceGtagId, {
     cookie_domain: window.location.hostname,
-    cookie_flags: 'SameSite=None;Secure',
+    cookie_flags: 'SameSite=None;Secure'
   });
 }
diff --git a/src/js/theme-detection.js b/src/js/theme-detection.js
@@ -1,8 +1,10 @@
+/* global localStorage */
+
 (() => {
   const systemMode = window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light';
   const preferredTheme = localStorage.getItem('preferred-theme');
 
-  function setTheme(theme) {
+  function setTheme (theme) {
     document.documentElement.setAttribute('data-theme-mode', theme === 'system' ? systemMode : theme);
   }
 

diff --git a/src/js/theme-switcher.js b/src/js/theme-switcher.js
@@ -1,3 +1,5 @@
+/* global localStorage */
+
 (() => {
   const themeSwitcher = document.querySelector('#theme-switcher');
   const preferredTheme = localStorage.getItem('preferred-theme') ?? 'system';

diff --git a/src/js/toc.js b/src/js/toc.js
@@ -13,12 +13,12 @@
     if (targetElement) {
       scrollItems.push({
         offset: targetElement.getBoundingClientRect().top + document.documentElement.scrollTop - 70,
-        element: item,
+        element: item
       });
     }
   });
 
-  function updateActiveItems() {
+  function updateActiveItems () {
     const scrollPosition = window.scrollY;
 
     const activeItem = scrollItems.reduce((closestItem, currentItem) => {