Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on 3 OS-es #169

Closed
wants to merge 4 commits into from
Closed

Run unit tests on 3 OS-es #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b715800
Fix CS and a typo
szepeviktor Oct 31, 2023
c31aed0
Run unit tests on 3 OS-es
szepeviktor Oct 31, 2023
c80778d
Actually use os
szepeviktor Oct 31, 2023
801efea
Fix coverage driver
szepeviktor Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/back-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,18 @@ jobs:
strategy:
fail-fast: false
matrix:
os:
- "macos-latest"
- "ubuntu-latest"
- "windows-latest"
php-version:
- "8.1"
- "8.2"
dependencies:
- "lowest"
- "locked"
- "highest"
runs-on: "ubuntu-22.04"
runs-on: "${{ matrix.os }}"
timeout-minutes: 5
steps:
-
Expand All @@ -64,6 +68,7 @@ jobs:
with:
php-version: "${{ matrix.php-version }}"
extensions: "dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, gd, fileinfo, exif"
coverage: "pcov"
-
name: "Setup problem matcher for PHPUnit"
run: |
Expand Down
2 changes: 1 addition & 1 deletion src/Columns/Column.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function searchWithQuery(Closure $callback): static
}

/**
* Resolve the serach query.
* Resolve the search query.
*/
public function resolveSearchQuery(Request $request, Builder $query, mixed $value): Builder
{
Expand Down
1 change: 0 additions & 1 deletion src/Filters/Search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
use Cone\Root\Columns\Columns;
use Cone\Root\Columns\Relation;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;

class Search extends RenderableFilter
Expand Down
Loading