Skip to content

Commit

Permalink
Fix dark/light mode logo in README
Browse files Browse the repository at this point in the history
  • Loading branch information
@szepeviktor
szepeviktor authored Jul 29, 2023
1 parent cf13781 commit 2cadad8
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<p>
<a href="https://root.conedevelopment.com/#gh-light-mode-only">
<br/>
<img src="./.github/root-logo-dark.svg" alt="Root" width="100">
<br/>
</a>
<a href="https://root.conedevelopment.com/#gh-dark-mode-only">
<br/>
<img src="./.github/root-logo-light.svg" alt="Root" width="100">
<br/>
<a href="https://root.conedevelopment.com/">
<br>
<picture>
<source media="(prefers-color-scheme: light)" srcset="./.github/root-logo-dark.svg">
<source media="(prefers-color-scheme: dark)" srcset="./.github/root-logo-light.svg">
<img alt="Root" width="100" src="./.github/root-logo-light.svg">
</picture>
<br>
</a>
</p>

Expand Down

2 comments on commit 2cadad8

@szepeviktor
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamlaki I've seen in another repo that the second <source> element is not necessary.

@adamlaki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because of the fallback you are right. I've changed it at 4 places and it is just more explicit. :|

Please sign in to comment.