cleanup

conedevelopment · Feb 19, 2024 · 194ad12 · 194ad12
1 parent 9456cd2
commit 194ad12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/Interfaces/Models/Transaction.php b/src/Interfaces/Models/Transaction.php
@@ -2,7 +2,6 @@
 
 namespace Cone\Bazar\Interfaces\Models;
 
-use DateTimeInterface;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
 interface Transaction
@@ -25,7 +24,7 @@ public function pending(): bool;
     /**
      * Mark the transaction as completed.
      */
-    public function markAsCompleted(?DateTimeInterface $date = null): void;
+    public function markAsCompleted(): void;
 
     /**
      * Mark the transaction as pending.

diff --git a/src/Models/Transaction.php b/src/Models/Transaction.php
@@ -152,12 +152,10 @@ public function pending(): bool
     /**
      * Mark the transaction as completed.
      */
-    public function markAsCompleted(?DateTimeInterface $date = null): void
+    public function markAsCompleted(): void
     {
-        $date = $date ?: Date::now();
-
-        if ($this->pending() || $this->completed_at->notEqualTo($date)) {
-            $this->setAttribute('completed_at', $date)->save();
+        if ($this->pending()) {
+            $this->setAttribute('completed_at', Date::now())->save();
 
             TransactionCompleted::dispatch($this);
         }