Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also update INCLUDE/LIB when not building packages #90

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

h-vetinari
Copy link
Member

In conda-forge/pytorch-cpu-feedstock#328, we want to move the library portion of pytorch (including the import libraries) to %LIBRARY_LIB% (to fix conda-forge/pytorch-cpu-feedstock#327); however, there are some pytorch compilation tests that then won't find those libs, because they're not looking in that directory by default.

This is in contrast to our compilers on UNIX, which add $PREFIX/lib to LDFLAGS not just for building packages, but also when activated compilers are in a regular environment (which is the case when we're running tests for pytorch, for example).

So mirror the setup from GCC here, which would allow us to fully move all the import libraries for libtorch to %LIBRARY_LIB%, without having to patch individual dependent packages to look in there specifically.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12924565560. Examine the logs at this URL for more detail.

@isuruf
Copy link
Member

isuruf commented Jan 23, 2025

Thanks

@isuruf isuruf merged commit 7c5cb05 into conda-forge:main Jan 23, 2025
21 checks passed
@h-vetinari h-vetinari deleted the LIB branch January 23, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows C extension compilation issues
3 participants