also update INCLUDE/LIB when not building packages #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conda-forge/pytorch-cpu-feedstock#328, we want to move the library portion of
pytorch
(including the import libraries) to%LIBRARY_LIB%
(to fix conda-forge/pytorch-cpu-feedstock#327); however, there are some pytorch compilation tests that then won't find those libs, because they're not looking in that directory by default.This is in contrast to our compilers on UNIX, which add
$PREFIX/lib
toLDFLAGS
not just for building packages, but also when activated compilers are in a regular environment (which is the case when we're running tests for pytorch, for example).So mirror the setup from GCC here, which would allow us to fully move all the import libraries for
libtorch
to%LIBRARY_LIB%
, without having to patch individual dependent packages to look in there specifically.