Add py-fann2 recipe #4528
Add py-fann2 recipe #4528
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/py-fann2:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
This recipe depends on #4527 |
recipes/py-fann2/meta.yaml
Outdated
| name: py-fann2 | ||
| version: "1.1.0" | ||
|
|
||
| source: |
There was a problem hiding this comment.
Please use the standard syntax from the example
There was a problem hiding this comment.
@CJ-Wright I patched the source by way of an extra git commit on my fork of their project. Is that frowned on?
When you say to use the standard syntax, do you mean to specify the version and such as variables at the top that are reused throughout the meta.yaml file?
There was a problem hiding this comment.
Yes https://conda-forge.org/docs/meta.html#build-from-tarballs-not-repos
You can put patches in the recipe. https://conda.io/docs/user-guide/tasks/build-packages/define-metadata.html#patches
recipes/py-fann2/meta.yaml
Outdated
| build: | ||
| skip: True # [win] | ||
| number: 0 | ||
| # noarch_python: True |
- Use source as is - Fill out about: section
… on windows Skip building on windows because the fann2 package doesn't build there yet [skip appveyor]
|
@CJ-Wright I think that I have addressed your requests, and this branch is now passing. Thanks for the feedback and patience. Let me know if you see something more that needs to be changed. |
recipes/py-fann2/meta.yaml
Outdated
| build: | ||
| number: 0 | ||
| script: python setup.py install --single-version-externally-managed --record=record.txt | ||
| # Skip the win build because fann2 doesn't build there yet |
There was a problem hiding this comment.
Would you mind removing this comment? When you commit please use [ci skip] [circle skip] [travis skip] to skip the CIs. #1148
…ause fann2 isn't built there yet. [ci skip] [circle skip] [travis skip] [skip appveyor]
recipes/py-fann2/meta.yaml
Outdated
|
|
||
| about: | ||
| home: https://github.com/FutureLinkCorporation/fann2 | ||
| license: LGPL2.1 |
There was a problem hiding this comment.
LGPL-2.1 from https://opensource.org/licenses/alphabetical
|
Thanks @CJ-Wright for your help. |
|
Np, good luck with the feedstock! |
If the import test fails, I may need help. The import test is failing on my system during the build process, but if I forgo the test and install the package, then it seems to succeed.