Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clRNG #3236

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Add clRNG #3236

merged 1 commit into from
Jul 7, 2017

Conversation

jakirkham
Copy link
Member

Fixes #3187

Adds a package for clRNG. This builds heavily off of the build strategy used by PyOpenCL and clBLAS.

Would appreciate feedback from interested/knowledgeable parties. Also would welcome interested parties as maintainers.

Note: Some of the build features won't come into play until the feedstock.

cc @inducer

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clrng) and found it was in an excellent condition.

@inducer
Copy link
Contributor

inducer commented Jul 6, 2017

Random123 is a fantastic CL RNG library. (I've included it in PyOpenCL.)

@jakirkham
Copy link
Member Author

Adding a Random123 package would be a good idea too. Looks like it is header only. Does it have any compiler constraints like needing C++11 or similar?

@jakirkham
Copy link
Member Author

Actually looks like clRNG has vendored Random123 for internal use.

@jakirkham jakirkham force-pushed the add_clrng branch 2 times, most recently from 593f372 to 2fe8f30 Compare July 6, 2017 17:52
# #
# xref: https://github.com/clMathLibraries/clRNG/issues/11 #
#############################################################
skip: True # [(win and py35) or (win32 and py36)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping Python 3.5 as Python 3.5 and Python 3.6 use the same VC runtime version. So either will work for our purposes here. This is typical.

What is worth noting is that VS 2015 32-bit builds fail. This log demonstrates the build failure. An issue has already been raised about this upstream. ( clMathLibraries/clRNG#11 ) As there doesn't seem to be a patch we can use to fix this, we merely disable those builds. VS 2015 64-bit builds seem to build fine.

@jakirkham jakirkham merged commit a020dd1 into conda-forge:master Jul 7, 2017
@jakirkham jakirkham deleted the add_clrng branch July 7, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants