-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clRNG #3236
Add clRNG #3236
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Random123 is a fantastic CL RNG library. (I've included it in PyOpenCL.) |
Adding a Random123 package would be a good idea too. Looks like it is header only. Does it have any compiler constraints like needing C++11 or similar? |
Actually looks like clRNG has vendored Random123 for internal use. |
593f372
to
2fe8f30
Compare
# # | ||
# xref: https://github.com/clMathLibraries/clRNG/issues/11 # | ||
############################################################# | ||
skip: True # [(win and py35) or (win32 and py36)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping Python 3.5 as Python 3.5 and Python 3.6 use the same VC runtime version. So either will work for our purposes here. This is typical.
What is worth noting is that VS 2015 32-bit builds fail. This log demonstrates the build failure. An issue has already been raised about this upstream. ( clMathLibraries/clRNG#11 ) As there doesn't seem to be a patch we can use to fix this, we merely disable those builds. VS 2015 64-bit builds seem to build fine.
Fixes #3187
Adds a package for clRNG. This builds heavily off of the build strategy used by PyOpenCL and clBLAS.
Would appreciate feedback from interested/knowledgeable parties. Also would welcome interested parties as maintainers.
Note: Some of the build features won't come into play until the feedstock.
cc @inducer